Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding types #15

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

adding types #15

wants to merge 7 commits into from

Conversation

AntanasGa
Copy link

I'm still having issues with the test file receiving types

Comment on lines +114 to +119
/**
* @typedef TestValue
* @property {string} key
* @property {number} value
*/

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure if this is the best option, but its the one i found for jsdoc, it comes along with:

let results = /** @type {TestValue[]} */ ( await ComfyDB.Search( { where: { key: { contains: "increment" } } } ) );

@AntanasGa AntanasGa marked this pull request as ready for review September 26, 2023 19:19
@AntanasGa
Copy link
Author

Haven't ran the tests because i did not have mongo

Comment on lines +63 to +64
lib/

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

depending on how it's deployed this might have to be removed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant