Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add multiple tab editor #1598

Draft
wants to merge 9 commits into
base: master
Choose a base branch
from
Draft

Conversation

danipaniii
Copy link
Contributor

@danipaniii danipaniii commented Apr 12, 2023

Closes #1403 .

Since I did not want to spend a lot of time, fixing the dependency issues that arised in the fork of the other PR, I started to work on this Issue on my own Fork.
Nevertheless while working on this issue I came across multiple challenges that are still work in progress.
Here I made a list:

  • The styling needs to be adjusted so that the editor will be shown in the tab.
  • The styling needs to be adjusted, so that the TabView header is scrollable and it is possible to see the arrow buttons to move the header
  • When selecting a file in the file tree, this file get's marked as selected, should we open a tab of another file in the TabView and make changes there, it will get seen as the file, that has been selected through the file tree, is where changes have been made. So when changing tabs, this selection should also change to the according file
  • When selecting a file, somehow the code gets executed twice and the value of the file get's read in the second iteration
  • When currently changing the tab, the activeIndex variable get's changed, but even after updating the TabView, the selected Tab is not changing. So I am thinking to implement it according to the documentation: https://primereact.org/tabview/. But therefore the const EditorView would have to become a function.

This change is Reviewable

@danipaniii danipaniii marked this pull request as draft April 12, 2023 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] - Add possibility to use Multiple Editor Tabs in the Config Server UI
1 participant