fix misleading listen address in documentation #516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A DHCP server should probably always listen on `0.0.0.0` when we're working on it in development and testing. Why? I believe normal DHCP requests are sent as broadcasts to `255.255.255.255`... I believe when its broadcasted, every single UDP packet regardless of where it ends up, will have `255.255.255.255` as the destination address. And since `255.255.255.255` != `127.0.0.1`, the UDP listener will ignore it. We can tell our UDP listener to listen on `255.255.255.255` but then it will ONLY receive these "normal" DHCP broadcast packets. If someone tries to send a datagram to it directly (on a specific IP like `127.0.0.1`, `192.168.69.1` etc) it wont be received. So i think `0.0.0.0` is appropriate here, considering that it's already being told to listen on a specific interface.
|
Please sign the commit. More details in: |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #516 +/- ##
==========================================
- Coverage 73.35% 73.06% -0.29%
==========================================
Files 81 89 +8
Lines 5104 5491 +387
==========================================
+ Hits 3744 4012 +268
- Misses 1217 1324 +107
- Partials 143 155 +12 ☔ View full report in Codecov by Sentry. |
pmazzini
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A DHCP server should probably always listen on
0.0.0.0when we're working on it in development and testing.Why?
I believe normal DHCP requests are sent as broadcasts to
255.255.255.255... I believe when its broadcasted, every single UDP packet regardless of where it ends up, will have255.255.255.255as the destination address. And since255.255.255.255!=127.0.0.1, the UDP listener will ignore it.We can tell our UDP listener to listen on
255.255.255.255but then it will ONLY receive these "normal" DHCP broadcast packets. If someone tries to send a datagram to it directly (on a specific IP like127.0.0.1,192.168.69.1etc) it wont be received.So i think
0.0.0.0is appropriate here, considering that it's already being told to listen on a specific interface.