Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document stack traces in TS SDK #794

Merged
merged 3 commits into from
May 27, 2024
Merged

Conversation

BrunoScheufler
Copy link
Contributor

This adds a section on preserving stack traces for the TypeScript SDK, thank you @jpwilliams for suggesting this! Related thread: https://inngest.slack.com/archives/C05PV209Y66/p1716478919426769

Copy link

vercel bot commented May 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
website ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 27, 2024 8:28am

Copy link
Contributor

@sylwiavargas sylwiavargas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, Bruno!

I've added two suggestions to manage readers' attention more effectively. I'm leaving them to your judgement and approving the PR already.

@BrunoScheufler
Copy link
Contributor Author

Much better, thank you @sylwiavargas!

@BrunoScheufler BrunoScheufler merged commit 738a751 into main May 27, 2024
4 of 5 checks passed
@BrunoScheufler BrunoScheufler deleted the bruno/document-stack-traces branch May 27, 2024 08:29
Copy link
Member

@jpwilliams jpwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants