Web types #351
Open
Web types #351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Will need update of .github/workflows/build-workflow.yml Under steps add: - run: npm run update-web-types
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
web-types.json should probably not be inside this PR, as it is supposed to be generated automatically on github guild |
Testing that made it into the PR :/
Testing that made it into the PR :/ But first I deleted the file, not the changes Amending
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce?
Feature improved developer experience (DX)
What is the current behavior?
Improve editor support via Web Types #299
What is the new behavior?
Added script command "update-web-types" in package.json to run update-web-types with the argument
of the new config file: styleguide.config.ts.
This will need to be added to the .github/workflows/build-workflow.yml for creating the web-types.json file.
Does this PR introduce a breaking change?
N/A
Other information:
https://blog.jetbrains.com/webstorm/2021/01/web-types/
https://github.com/JetBrains/web-types
https://github.com/JetBrains/web-types/tree/master/gen/vue-docgen-web-types