Update to Dune 3.0, fix build of benchmarks, various fixes #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR also somewhat supersedes #206, although mine doesn't use Dune to generate the opam files. |
They're intended for REPL top-level expressions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear maintainer,
This PR updates the build system to depend on Dune 3.0 as it gives many niceties and new warnings. Accordingly, it also fixes the new warnings.
I've also seen that the benchmark wouldn't build so I've updated them for core_unix v0.15.0, and declared their dependencies for testing in the opam files.
Last but not least, angstrom-unix, angstrom-lwt-unix and angstrom-async now depend on the same version of angstrom as they are. Although this could be lifted, I think it greatly simplifies integration and debugging.
Thanks!