Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make parser combiner lazy #210

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Make parser combiner lazy #210

wants to merge 1 commit into from

Conversation

RCmerci
Copy link

@RCmerci RCmerci commented Feb 24, 2021

related to #209

@SGrondin
Copy link

SGrondin commented Oct 4, 2021

I've been running into stack overflow on 0.15.0 as well, which is surprising to me because #186 and #187 are very similar to the changes I've made on my old fork which does not have stack overflow issues.

It turns out the reason is the changes made by #186 and #187 aren't fully lazy.

This PR fixed all remaining stack overflows on 0.15.0 for me! 🎉 It passes all my tests on SZXX. However the impact on performance seems to be a slowdown of ~55%. I'd still support merging it, maybe along with #217 to (more than) cancel out the impact on performance?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@RCmerci @SGrondin