Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: readd templatefile support #3041

Merged
merged 1 commit into from Apr 30, 2024
Merged

feat: readd templatefile support #3041

merged 1 commit into from Apr 30, 2024

Conversation

hugorut
Copy link
Contributor

@hugorut hugorut commented Apr 26, 2024

Changes isPathInRepo to use wd directory instead of RepoPath which is likely incorrect for Terragrunt projects.

The RepoPath property that is infered from detected projects was returning full project path for detected projects when the autdetected project was inferred from a config file. A fix for this will be addressed in a further PR.

To fix the templatefile logic I've opted to use the os working directory instead, as this is more robust.

@hugorut hugorut self-assigned this Apr 29, 2024
@hugorut hugorut force-pushed the fix/repo-path-wd branch 5 times, most recently from f94233a to e8342c7 Compare April 29, 2024 09:10
Changes `isPathInRepo` to use wd directory instead of `RepoPath` which is likely incorrect for
Terragrunt projects.

The `RepoPath` property that is infered from detected projects was returning full project
path for detected projects when the autdetected project was inferred from a config file. A
fix for this will be addressed in a further PR.

To fix the templatefile logic I've opted to use the os working directory instead, as this is more
robust.
@hugorut hugorut marked this pull request as ready for review April 29, 2024 09:52
@hugorut hugorut requested a review from aliscott April 29, 2024 09:56
@hugorut hugorut merged commit d38c888 into master Apr 30, 2024
9 of 10 checks passed
@hugorut hugorut deleted the fix/repo-path-wd branch April 30, 2024 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants