Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docker): Build ARM64 images #2702

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

torqu3e
Copy link

@torqu3e torqu3e commented Oct 13, 2023

Updates the Github action for building the docker images. Uses parallel runners to build image for each platform and then push the manifest after the build. Cross arch build here should be a relative non issue due to the infrequency of action run (~once every 2 months).

Updates the Github action for building the docker images. Uses parallel runners to build image for each platform and then push the manifest after the build. Cross arch build here should be a relative non issue due to the infrequency of action run (~once every 2 months).
@torqu3e torqu3e requested a review from a team as a code owner October 13, 2023 03:32
@CLAassistant
Copy link

CLAassistant commented Oct 13, 2023

CLA assistant check
All committers have signed the CLA.

@aliscott
Copy link
Member

Thanks @torqu3e 🙏. It looks like this only updates the Dockerfile.ci (infracost:ci-*) images. I think we would want this to work on both the Dockerfile and the Dockerfile.ci images.

Any ideas how long this pipeline will take to run? One of the reasons we have a infrequent release cycle is because of the time for these pipelines to run so I'm hesitant about making it significantly slower.

@torqu3e
Copy link
Author

torqu3e commented Oct 13, 2023

@aliscott I don't see any mention of Dockerfile by itself in any other workflows. There's the create-test-image one which I've not seen run. Where are you referring to for the other files?

This will likely add some more time though hopefully not humongously so because of the parallel image builds. The majority of the time presently is in the go binary build which I can try to look into separate from this.

@aliscott
Copy link
Member

@torqu3e the Dockerfile build is here:

- name: Build and push Docker images
.

I'll see if I can run this in a test environment to see how much time it adds, but not sure how easy that will be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants