Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#630 Add in net 5 and make dependency conditional #631

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

thompson-tomo
Copy link

Closes #630

Proposed Changes

Adds in net 5 so a dependency can be removed

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • dotnet test completes successfully
  • Commit messages are conventional
  • Sign CLA (if not already signed)

Copy link
Contributor

@bednar bednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @thompson-tomo,

Thank you for your PR 👍.

Could you please share the reasoning behind this change? Have you attempted to use ExcludeAssets="All" and then manually add the remaining dependencies to your project?

Client/Client.csproj Outdated Show resolved Hide resolved
@thompson-tomo
Copy link
Author

No I haven't gone done the path of excluding dependencies & explicitly re-adding them. As I feel Going down the path of simplifying dependencies in the source package is easier to maintain going forward & everyone using a newer target benefits.

@thompson-tomo thompson-tomo force-pushed the chore/#630_AddTFMAndTweakDependencies branch from c9789a4 to 9270c43 Compare April 9, 2024 11:16
@thompson-tomo thompson-tomo requested a review from bednar May 8, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reduce dependencies by adding TFM
2 participants