Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): Install AsyncStorage as dependency #1477

Closed
wants to merge 2 commits into from

Conversation

carmeli-tamir
Copy link
Contributor

Without AsyncStorage dependency, the instruction in "Step 2 - Initialization" simply doesn´t work if the developer app doesn´t already use AsyncStorage, since it does ´Reactotron.setAsyncStorageHandler(AsyncStorage)´

If the developer app already uses AsyncStorage, this is harmless.

Please verify the following:

  • yarn build-and-test:local passes
  • I have added tests for any new features, if relevant
  • README.md (or relevant documentation) has been updated with your changes

Describe your PR

@morganick
Copy link
Contributor

Hey @carmeli-tamir, it should work without Async Storage. However, I noticed late last week that I forgot to update the docs so that setAsyncStorageHandler was not part of the base configuration 😅 If you remove that from the config, it should work as you expect it without Async Storage. We didn't want you to have to have Async Storage installed in your app in order to use Reactotron.

Let me know if you run into further issue.

Without AsyncStorage dependency, the instruction in "Step 2 - Initialization" simply doesn´t work if the developer app doesn´t already use AsyncStorage, since it does ´Reactotron.setAsyncStorageHandler(AsyncStorage)´

Since AsyncStorage isn´t required for the base configuration, remove it.
@carmeli-tamir
Copy link
Contributor Author

Thanks for the clarification. I´ve sumbitted a PR to remove AsyncStorage from the base config. https://github.com/infinitered/reactotron/pull/1479/files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants