Skip to content
This repository has been archived by the owner on Jul 5, 2020. It is now read-only.

Commit

Permalink
Merge pull request #48 from infOpen/remove_critical_data_logging
Browse files Browse the repository at this point in the history
Add no_log statements when use critical data
  • Loading branch information
achaussier committed Apr 24, 2016
2 parents b8ec0ed + 8bf10dd commit 2e73e67
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 0 deletions.
3 changes: 3 additions & 0 deletions tasks/manage_credentials.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
private_key_passphrase: "{{ item.private_key_passphrase }}"
description: "{{ item.description }}"
state: "{{ item.state }}"
no_log: True
register: 'jenkins_change_ssh_credentials'
with_items: "{{ jenkins_credentials }}"
when: "{{ item.private_key_source_type is defined }}"
Expand All @@ -41,6 +42,7 @@
description: "{{ item.description }}"
password: "{{ item.password }}"
state: "{{ item.state }}"
no_log: True
register: 'jenkins_change_password_credentials'
with_items: "{{ jenkins_credentials }}"
when: "{{ item.password is defined }}"
Expand All @@ -57,6 +59,7 @@
text: "{{ item.text }}"
description: "{{ item.description }}"
state: "{{ item.state }}"
no_log: True
register: 'jenkins_change_text_credentials'
with_items: "{{ jenkins_credentials }}"
when: "{{ item.text is defined }}"
3 changes: 3 additions & 0 deletions tasks/manage_main_config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
authorization_strategy: "{{ jenkins_authorization_strategy }}"
crumb_issuer: "{{ jenkins_crumb_issuer }}"
use_private_key: False
no_log: True
register: 'jenkins_change_deployment_user_without_ssh_key'
ignore_errors: True
with_items:
Expand All @@ -34,6 +35,7 @@
security_realm: "{{ jenkins_security_realm }}"
authorization_strategy: "{{ jenkins_authorization_strategy }}"
crumb_issuer: "{{ jenkins_crumb_issuer }}"
no_log: True
register: 'jenkins_change_deployment_user'
with_items:
- username: "{{ jenkins_deployment_user.username }}"
Expand All @@ -57,6 +59,7 @@
security_realm: "{{ jenkins_security_realm }}"
authorization_strategy: "{{ jenkins_authorization_strategy }}"
crumb_issuer: "{{ jenkins_crumb_issuer }}"
no_log: True
register: 'jenkins_change_users_or_security'
with_items: "{{ jenkins_users }}"
when: "{{ jenkins_manage_users_and_security }}"
Expand Down
5 changes: 5 additions & 0 deletions tasks/manage_plugins_config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
smtp_port: "{{ jenkins_plugin_mailer_smtp_port }}"
smtp_user: "{{ jenkins_plugin_mailer_smtp_user }}"
use_ssl: "{{ jenkins_plugin_mailer_use_ssl }}"
no_log: True
register: 'jenkins_change_plugin_mailer'
when: "{{ 'mailer' in (jenkins_plugins | map(attribute='name')) }}"

Expand Down Expand Up @@ -62,6 +63,7 @@
public_key: "{{ jenkins_plugins_debian_package_builder_gpg.public_key }}"
private_key: "{{ jenkins_plugins_debian_package_builder_gpg.private_key }}"
passphrase: "{{ jenkins_plugins_debian_package_builder_gpg.passphrase }}"
no_log: True
register: 'jenkins_change_plugin_debian_package_builder_gpg'
when: "{{ 'debian-package-builder' in
(jenkins_plugins | map(attribute='name')) }}"
Expand Down Expand Up @@ -91,6 +93,7 @@
key_path: "{{ item.key_path }}"
options: "{{ item.options }}"
state: "{{ item.state }}"
no_log: True
register: 'jenkins_change_plugin_debian_package_builder_repo'
with_items: "{{ jenkins_plugins_debian_package_builder_repo }}"
when: "{{ 'debian-package-builder' in
Expand All @@ -104,6 +107,7 @@
api_token: "{{ jenkins_plugins_gitlab_api_token }}"
host_url: "{{ jenkins_plugins_gitlab_host_url }}"
ignore_cert_error: "{{ jenkins_plugins_gitlab_ignore_cert_error }}"
no_log: True
register: 'jenkins_change_plugin_gitlab'
when: "{{ 'gitlab-plugin' in (jenkins_plugins | map(attribute='name')) }}"

Expand All @@ -117,6 +121,7 @@
v2_enabled: "{{ jenkins_plugins_hipchat_v2_enabled }}"
room: "{{ jenkins_plugins_hipchat_room }}"
send_as: "{{ jenkins_plugins_hipchat_send_as }}"
no_log: True
register: 'jenkins_change_plugin_hipchat'
when: "{{ 'hipchat' in (jenkins_plugins | map(attribute='name')) }}"

Expand Down

0 comments on commit 2e73e67

Please sign in to comment.