Update ecdsa-test.js, fix test failure #193
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
new node-bn.js 5.0.0-1 gives error when the string passed to sign function is not in hex format.
curve secp256k1
should have `signature.s <= keys.ec.nh`:
�[0m�[31m Error: Invalid character in hello�[0m�[90m
at assert (/usr/share/nodejs/bn.js/lib/bn.js:6:21)
at parseHex (/usr/share/nodejs/bn.js/lib/bn.js:214:5)
at BN._parseHex (/usr/share/nodejs/bn.js/lib/bn.js:241:11)
at BN.init [as _init] (/usr/share/nodejs/bn.js/lib/bn.js:97:12)
at new BN (/usr/share/nodejs/bn.js/lib/bn.js:39:12)
at EC.sign (lib/elliptic/ec/index.js:99:27)
at KeyPair.sign (lib/elliptic/ec/key.js:108:18)
at Context.<anonymous> (test/ecdsa-test.js:64:25)
at callFn (/usr/lib/nodejs/mocha/lib/runnable.js:354:21)
at Test.Runnable.run (/usr/lib/nodejs/mocha/lib/runnable.js:346:7)
at Runner.runTest (/usr/lib/nodejs/mocha/lib/runner.js:442:10)
at /usr/lib/nodejs/mocha/lib/runner.js:560:12
at next (/usr/lib/nodejs/mocha/lib/runner.js:356:14)
at /usr/lib/nodejs/mocha/lib/runner.js:366:7
at next (/usr/lib/nodejs/mocha/lib/runner.js:290:14)
at /usr/lib/nodejs/mocha/lib/runner.js:329:7
at done (/usr/lib/nodejs/mocha/lib/runnable.js:301:5)
at callFn (/usr/lib/nodejs/mocha/lib/runnable.js:372:7)
at Hook.Runnable.run (/usr/lib/nodejs/mocha/lib/runnable.js:346:7)
at next (/usr/lib/nodejs/mocha/lib/runner.js:304:10)
at Immediate._onImmediate (/usr/lib/nodejs/mocha/lib/runner.js:334:5)
�[0m
|
Currently |
|
because one day bn.js will be updated, and this is a retro-compatible approach |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
new node-bn.js 5.0.0-1 gives error when the string passed to sign function is not in hex format.
�[0m�[31m Error: Invalid character in hello�[0m�[90m
at assert (/usr/share/nodejs/bn.js/lib/bn.js:6:21)
at parseHex (/usr/share/nodejs/bn.js/lib/bn.js:214:5)
at BN._parseHex (/usr/share/nodejs/bn.js/lib/bn.js:241:11)
at BN.init [as _init] (/usr/share/nodejs/bn.js/lib/bn.js:97:12)
at new BN (/usr/share/nodejs/bn.js/lib/bn.js:39:12)
at EC.sign (lib/elliptic/ec/index.js:99:27)
at KeyPair.sign (lib/elliptic/ec/key.js:108:18)
at Context. (test/ecdsa-test.js:64:25)
at callFn (/usr/lib/nodejs/mocha/lib/runnable.js:354:21)
at Test.Runnable.run (/usr/lib/nodejs/mocha/lib/runnable.js:346:7)
at Runner.runTest (/usr/lib/nodejs/mocha/lib/runner.js:442:10)
at /usr/lib/nodejs/mocha/lib/runner.js:560:12
at next (/usr/lib/nodejs/mocha/lib/runner.js:356:14)
at /usr/lib/nodejs/mocha/lib/runner.js:366:7
at next (/usr/lib/nodejs/mocha/lib/runner.js:290:14)
at /usr/lib/nodejs/mocha/lib/runner.js:329:7
at done (/usr/lib/nodejs/mocha/lib/runnable.js:301:5)
at callFn (/usr/lib/nodejs/mocha/lib/runnable.js:372:7)
at Hook.Runnable.run (/usr/lib/nodejs/mocha/lib/runnable.js:346:7)
at next (/usr/lib/nodejs/mocha/lib/runner.js:304:10)
at Immediate._onImmediate (/usr/lib/nodejs/mocha/lib/runner.js:334:5)
�[0m