Editable submission status #6186
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duartegalvao
requested changes
Feb 16, 2024
indico/modules/events/editing/client/js/management/editable_type/EditableList.jsx
Outdated
Show resolved
Hide resolved
indico/modules/events/editing/client/js/management/editable_type/EditableList.jsx
Outdated
Show resolved
Hide resolved
indico/modules/events/editing/client/js/management/editable_type/EditableList.jsx
Outdated
Show resolved
Hide resolved
Comment on lines
+254
to
+257
| submitter_acceptance = fields.Method('_get_submitter_acceptance') | ||
|
|
||
| def _get_submitter_acceptance(self, editable): | ||
| return editable.latest_revision.type == RevisionType.changes_acceptance |
There was a problem hiding this comment.
Note: we are awaiting a response from JACoW on whether we can fully add a new editable state rather than using this "hack"
There was a problem hiding this comment.
Any news from JACoW about that?
tomasr8
reviewed
Feb 19, 2024
indico/modules/events/editing/client/js/management/editable_type/EditableList.jsx
Outdated
Show resolved
Hide resolved
indico/modules/events/editing/client/js/management/editable_type/EditableList.jsx
Outdated
Show resolved
Hide resolved
tomasr8
reviewed
Mar 20, 2024
indico/modules/events/editing/client/js/management/editable_type/EditableList.jsx
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #6185