Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update node installation to automatically install the correct versions. #968

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

david-pfx
Copy link

Fixes #955

DEVELOPMENT.md Outdated
```

The specific packages and versions are now in `package.json`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor suggestion, but this could be understood as "After running the command, the specific packages and versions are now in package.json.". Might be better to say "This will install the necessary packages as listed in package.json."

@@ -6,7 +6,7 @@ creates a highly compressed release build in bin of the contents of src

packages used:

npm i rimraf compress-images web-resource-inliner ncp [email protected] concat ycssmin terser gzipper html-minifier-terser glob
npm i rimraf compress-images web-resource-inliner ncp [email protected] concat ycssmin terser gzipper html-minifier-terser glob@8
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should probably remove this line (and maybe replace it with another line saying to use npm install to install the packages listed in package.json.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it was my code I would probably just delete it, or replace it with a reference back to DEVELOPMENT.md. Not really my decision, but feel free if so minded.

DEVELOPMENT.md Outdated Show resolved Hide resolved
increpare added a commit that referenced this pull request Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Node build fails with 'illegal characters in path'
2 participants