-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
attestation evindence broker: Initial implement #1500
Open
haosanzi
wants to merge
6
commits into
inclavare-containers:master
Choose a base branch
from
haosanzi:aeb
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jialez0
reviewed
Nov 25, 2021
attestation-evidence-broker/src/aeb_modules/sev_aeb/evidence.rs
Outdated
Show resolved
Hide resolved
attestation-evidence-broker/src/aeb_modules/sev_aeb/get_evidence.rs
Outdated
Show resolved
Hide resolved
attestation-evidence-broker/src/aeb_modules/sev_aeb/get_evidence.rs
Outdated
Show resolved
Hide resolved
attestation-evidence-broker/src/aeb_modules/sev_aeb/get_evidence.rs
Outdated
Show resolved
Hide resolved
attestation-evidence-broker/src/aeb_modules/sev_aeb/get_evidence.rs
Outdated
Show resolved
Hide resolved
A little suggestion: you can check your rust code with the following two commands:
|
jialez0
approved these changes
Nov 30, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. 👍
haosanzi
force-pushed
the
aeb
branch
3 times, most recently
from
December 2, 2021 06:31
4a14bcf
to
216d084
Compare
liangzhou121
approved these changes
Dec 2, 2021
jiazhang0
requested changes
Dec 29, 2021
jiazhang0
requested changes
Dec 29, 2021
Signed-off-by: Shirong Hao <[email protected]>
jiazhang0
reviewed
Jan 5, 2022
jiazhang0
requested changes
Jan 5, 2022
jiazhang0
requested changes
Jan 5, 2022
jiazhang0
requested changes
Jan 5, 2022
jiazhang0
requested changes
Jan 5, 2022
jiazhang0
requested changes
Jan 6, 2022
jiazhang0
reviewed
Jan 7, 2022
jiazhang0
requested changes
Jan 7, 2022
jiazhang0
requested changes
Jan 7, 2022
jiazhang0
reviewed
Jan 10, 2022
…ation evidence Signed-off-by: Shirong Hao <[email protected]>
Signed-off-by: Shirong Hao <[email protected]>
Signed-off-by: Shirong Hao <[email protected]>
…p driver Signed-off-by: Shirong Hao <[email protected]>
Signed-off-by: Shirong Hao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Shirong Hao [email protected]