feat: 'Split and Stitch' Encoding #257
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
…ssue-9--Split-and-Stitch-Encoding
Good - We've got segment encoding working. Hurray! - New user configurable settings for split and stitch, segment size. Not Yet Good - Concatenation is broken, only concats first segment. - No output subfolder to keep things tidy - Progress reporting is broken (expected) - No tidy up afterwards - No handling for jobs smaller than segment size - Celery chord is not durable - fails if a segment fails - Existing segments are not handled, just overwritten
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original issue description
I've been messing around with running separate FFmpeg processes on segments of the same video file.
There are a bunch of benefits here:
I've got this working reliably locally - with no performance gains obviously since I'm running all the FFmpeg processes on the same machine.
To get this working here we'll need a few things:
A new task to parse the original job into segmentsJob must be pickled, not sent as JSON. We need to transport Resolve's PyRemoteObj MediaPoolItem as task resultscloses #9