Feature: Time Based Form Goals #7384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… fields/queries (#7380) Co-authored-by: Ante Laca <[email protected]>
|
Build for QA, see https://github.com/impress-org/givewp/actions/runs/8986169359. |
jonwaldstein
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces time based form goals for the Visual Donation Form Builder, which includes a new "custom" settings (as opposed to "all time") with support for amount goals, donor goals, and donation goals with support for recurring donations.
Affects
Query results for all goal types have been updated, including Amount Raised, Donation Count, Donor Count, Subscription Initial Amount, Subscription Count, and Subscriber Count.
Additional Details
The new time-based settings are implemented using a new
DonationQuery(and relatedSubscriptionQuery. These new query classes are opinionated extensions of theQueryBuilderwith a fluid syntax designed for goal settings.Notably, the
DonationQuerysupports calculating a sum of the intended amount, which takes into account support for fee recovery and calculates goal progress excluding those fees.Visuals