Format donation count output in progress bar component #7209
+18
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit changes the return type of the getDonationCount function from int to string. It also introduces formatting, specifically disabling sanitization, decimal, and currency formatting options for the returned count, using the give_format_amount function.
The getDonationCount method now returns a formatted donation count string, instead of an int. A new method, getFormattedDonationCount, has been introduced to apply the give_format_amount function, turning off sanitization, decimal, and currency formatting. This results in a cleaner display of donation counts in the progress bar.
DevinWalker
changed the title
jonwaldstein
reviewed
Feb 1, 2024
| @@ -32,7 +32,7 @@ | |||
| </div> | |||
| <div part="stat-count" class="give-progress-bar-block__stat"> | |||
| <div part="stat-count-value"><?php | |||
| echo esc_html($this->getDonationCount()); ?></div> | |||
| echo esc_html($this->getFormattedDonationCount()); ?></div> | |||
There was a problem hiding this comment.
I think we could simplify this by using number_format directly instead of give_format_amount:
Suggested change
| echo esc_html($this->getFormattedDonationCount()); ?></div> | |
| echo esc_html(number_format($this->getDonationCount())); ?></div> |
|
This PR is stale because it has been open 45 days with no activity. Stale PRs will NOT be automatically closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #7208
Description
This resolves the issue with the "Donation" count total not being formatted properly.
I'm using
give_format_amount()for this, even though it's a total, not an amount because I didn't see any other generic non-currency-based way to do it. This seems to work fine, though.Affects
Progress bar component with donation counts.
Visuals
Before
After
Pre-review Checklist
@unreleasedtags included in DocBlocks