Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(web): page down shortcut #9397

Merged
merged 1 commit into from May 11, 2024
Merged

fix(web): page down shortcut #9397

merged 1 commit into from May 11, 2024

Conversation

martabal
Copy link
Member

fixes #9396

Copy link

Deploying immich with  Cloudflare Pages  Cloudflare Pages

Latest commit: 2b3fc8e
Status: ✅  Deploy successful!
Preview URL: https://92afde42.immich.pages.dev
Branch Preview URL: https://fix-page-down-shortcut.immich.pages.dev

View logs

@alextran1502 alextran1502 merged commit 8fdcaba into main May 11, 2024
23 of 24 checks passed
@alextran1502 alextran1502 deleted the fix/page-down-shortcut branch May 11, 2024 21:49
@oryjkov
Copy link

oryjkov commented May 13, 2024

I would have expected PgDn to scroll down by a single page of content, not jump to the bottom of the content, as it does with this change. Effectively it now does what the End key is already doing.

I don't think fixes #9396

@martabal
Copy link
Member Author

From the beginning, I had in mind that the behavior was to go to the very bottom/very top of the page. I guess the behavior you describe is good too (probably even better). Google Photos doesn't seem to move from one time bucket to another, it's just scrolling through more rows, but that has nothing to do with time buckets.

@oryjkov
Copy link

oryjkov commented May 14, 2024

google photos scrolls up/down by a single page of content when PgUp/PgDn is pressed (I tried in the Timeline and Album views). IMO that's what these keys should do.

@Snowknight26
Copy link
Contributor

Yep and ideally the browser should handle those without needing to rely on keydown.
#9448

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Page down doesn't work more than once in timeline
5 participants