Skip to content

Commit

Permalink
fix: maybe fix release.published event firing
Browse files Browse the repository at this point in the history
  • Loading branch information
iloveitaly committed Dec 29, 2023
1 parent 9e2e889 commit 51da49b
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 1 deletion.
5 changes: 5 additions & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,9 @@ jobs:
steps:
- name: Checkout
uses: actions/checkout@v4
with:
# https://stackoverflow.com/questions/60418323/triggering-a-new-workflow-from-another-workflow/60418414#60418414
token: ${{ secrets.GH_PERSONAL_TOKEN }}

- name: Trunk Check
uses: trunk-io/trunk-action@v1
Expand All @@ -38,7 +41,9 @@ jobs:
# TODO is there a way to set swift version explicitly?
- name: setup Xcode version
run: |
# output list of xcode app versions to easily update the selected version
ls /Applications
sudo xcode-select -s /Applications/Xcode_15.1.0.app
- name: Test
Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/notify-twitter.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,9 @@ on:
workflow_dispatch: null
release:
# publishes is fired when a release is created programmatically
# release must be created with a PAT, not the default token!
# https://stackoverflow.com/questions/59319281/github-action-different-between-release-created-and-published
# must be created with a PAT if automated
# https://github.com/peter-evans/create-pull-request/blob/main/docs/concepts-guidelines.md#workarounds-to-trigger-further-workflow-runs
types: [published]

jobs:
Expand Down

0 comments on commit 51da49b

Please sign in to comment.