Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit CI runtime on Windows runners #520

Merged
merged 2 commits into from
Mar 7, 2024

Conversation

glatterf42
Copy link
Member

@glatterf42 glatterf42 commented Mar 7, 2024

Currently, our CI is "failing" because the codecov-action gets stuck for Windows runners despite the last line showing info - 2024-03-07 05:18:14,167 -- Process Upload complete. It seems this success is not correctly registered so that the workflow doesn't move to the next job. See also

At the moment, this PR simply applies a time limit to this CI step (1 minute should be plenty for a step that usually takes ~5s), but the step will then still fail. So we might want to explore other options such as downgrading to codecov-action@v3.
Another option would probably be to run codecov as a command line tool manually.

How to review

Please check the added comment is enough to understand how/when to remove this temporary addition. The CI is not expected to pass on Windows runners.

PR checklist

  • Continuous integration checks all ✅
  • [ ] Add or expand tests; coverage checks both ✅ No intention to keep this change
  • [ ] Add, expand, or update documentation. No intention to keep this change
  • [ ] Update release notes. No intention to keep this change

@glatterf42 glatterf42 added bug ci Continuous integration labels Mar 7, 2024
@glatterf42 glatterf42 requested a review from khaeru March 7, 2024 10:38
@glatterf42 glatterf42 self-assigned this Mar 7, 2024
Copy link

codecov bot commented Mar 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.9%. Comparing base (809e28a) to head (6570925).

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #520   +/-   ##
=====================================
  Coverage   98.9%   98.9%           
=====================================
  Files         44      44           
  Lines       4795    4795           
=====================================
  Hits        4743    4743           
  Misses        52      52           

@khaeru
Copy link
Member

khaeru commented Mar 7, 2024

At the moment, this PR simply applies a time limit to this CI step (1 minute should be plenty for a step that usually takes ~5s), but the step will then still fail. So we might want to explore other options…

Can you please experiment with adding:

continue-on-error: true

…to only the one step you've modified? I think this should allow the overall jobs to succeed.

@glatterf42
Copy link
Member Author

Seems to work :)

@khaeru khaeru merged commit d202e01 into iiasa:main Mar 7, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug ci Continuous integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants