[muc] changeSubject errors should be propagated #596
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When Smack requests a subject change of a MUC, an error returned by the server (eg: 'forbidden') should be propagated (as suggested by the pre-existing javadoc).
|
This fixes the problem reported in https://discourse.igniterealtime.org/t/multiuserchat-changesubject-times-out-without-auth/ |
|
LGTM But could you change the type of the argument of the |
|
I tried, but apparently the ID is not set yet without building the stanza. |
guusdk
added a commit
to XMPP-Interop-Testing/smack-sint-server-extensions
that referenced
this pull request
May 23, 2024
…bject" of XEP-0045: "Multi-User Chat" Note that these tests will fail when using a version of Smack that does not fix a bug in its subject change implemetation. See igniterealtime/Smack#596
guusdk
added a commit
to XMPP-Interop-Testing/smack-sint-server-extensions
that referenced
this pull request
May 23, 2024
…bject" of XEP-0045: "Multi-User Chat" Note that these tests will fail when using a version of Smack that does not fix a bug in its subject change implementation. See igniterealtime/Smack#596
|
Fixed with 147071f |
guusdk
added a commit
to XMPP-Interop-Testing/smack-sint-server-extensions
that referenced
this pull request
Jun 14, 2024
…bject" of XEP-0045: "Multi-User Chat" Note that these tests will fail when using a version of Smack that does not fix a bug in its subject change implementation. See igniterealtime/Smack#596
Fishbowler
pushed a commit
to XMPP-Interop-Testing/smack-sint-server-extensions
that referenced
this pull request
Jun 20, 2024
…bject" of XEP-0045: "Multi-User Chat" Note that these tests will fail when using a version of Smack that does not fix a bug in its subject change implementation. See igniterealtime/Smack#596
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When Smack requests a subject change of a MUC, an error returned by the server (eg: 'forbidden') should be propagated (as suggested by the pre-existing javadoc).