Add no_std compatibility #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mo8it
approved these changes
Jul 10, 2023
|
There were already nostd tests. Maybe the CI does not run them? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for the effort in maintaining Typed Builder.
Our framework LibAFL is using Typed Builder in a no_std context and the recent update to 0.15.0 is breaking our library on bare metal targets.
In this PR, I introduce no_std compatibility. There is no downside, just an annotation and an import from core.
If you want to test it, use
cargo +nightly build -Zbuild-std=core --target aarch64-unknown-none(you may want it in the CI script eventually).