Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry build on license failure; retry pre-commit on dotnet-format failure #716

Merged
merged 5 commits into from
Jun 5, 2024

Conversation

mikeage
Copy link
Member

@mikeage mikeage commented May 19, 2024

Use an action that will automatically retry builds on license failures
Also retry pre-commit dotnet-format, if it fails

@mikeage mikeage added the infrastructure Build or tooling infrastructure label May 19, 2024
@mikeage
Copy link
Member Author

mikeage commented May 19, 2024

hmm, this worked on my fork. Need to see what's different here. Moving to draft for now

It didn't like the embedded newlines in the ANDROID_KEYSTORE_BASE64. I removed them; base64 doesn't care in any case.

@mikeage mikeage marked this pull request as draft May 19, 2024 15:23
@mikeage mikeage marked this pull request as ready for review May 19, 2024 16:12
@mikeage
Copy link
Member Author

mikeage commented May 19, 2024

I think this is ready, but I'd like to wait for two things:

  • Testing with a real license, since I think we saw more failures (that it might actually catch!) there
  • A fix for the git/git-lfs issue, so I don't have to do the workaround in cc07f10

@mikeage
Copy link
Member Author

mikeage commented May 23, 2024

Good news: when we had the not working UNITY_SERIAL, this retried perfectly. I'm going to wait on the git lfs fix, I think, because I don't like the hack here, but this is ready.

Github CI is currently broken when we have a git lfs clone due to
actions/runner-images#9883. Temporarily work
around this
@mikeage mikeage changed the title Retry build on license failure Retry build on license failure; retry pre-commit on dotnet-format failure May 27, 2024
@mikeage
Copy link
Member Author

mikeage commented May 27, 2024

Based on Wandalen/wretry.action#164, I unpacked the dotnet-format action so that we can rerun it on those annoying NuGet failures.

Here's a sample, from the testing I was doing on my fork: https://github.com/mikeage/open-brush/actions/runs/9250440297/job/25443964072

@mikeage mikeage merged commit 013fe41 into main Jun 5, 2024
42 checks passed
@mikeage mikeage deleted the infra/retry_license branch June 5, 2024 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure Build or tooling infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant