Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User overrides for platform settings #643

Draft
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

andybak
Copy link
Contributor

@andybak andybak commented Mar 5, 2024

No description provided.

@andybak
Copy link
Contributor Author

andybak commented Mar 5, 2024

So the plan is to get the user-friendly version of this out there so we can encourage people to try different settings and decide on better defaults. Once we have a good default we should move that settings into an in-app editable dialog.

However - I suspect most of these settings aren't terribly interesting or useful. So some can just live in the config file in perpetuity.

@mikeage mikeage added the enhancement Feature added label Mar 5, 2024
@mikeage
Copy link
Member

mikeage commented Mar 5, 2024

Should we revisit #108 in this context? :-)

Otherwise, looks good!

@andybak andybak marked this pull request as draft March 5, 2024 14:22
@andybak
Copy link
Contributor Author

andybak commented Mar 5, 2024

I've realised that most of the interesting performance stuff happens in AppQualitySettingLevels. I think you can already override this to some degree in the config but I need to investigate properly.

@andybak
Copy link
Contributor Author

andybak commented Mar 27, 2024

Undecided what to do with this. It's not amazingly useful unless we also investigate the auto-quality switching and undo the problems caused by #5 which disabled bloom but didn't remove or adjust the associated quality levels.

Therefore the quality level switching is behaving erratically. We should either reinstate/fix mobile bloom or remove the last two quality levels.

@andybak
Copy link
Contributor Author

andybak commented Apr 17, 2024

Thinking about this some more...

Some of differences between PC and Quest are where there's a separate mobile panel. It would be good to maybe bring some of these across where it's technically possible, initially hidden behind a config setting. "Select All/Invert Selection" springs to mind but I'm sure there's a list somewhere in the docs.

The only places we can't do this is where the required libraries are PC only. e.g. video rendering, fbx export, "export selected strokes" (which relies on USD).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature added
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants