Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: the icon will be removed when the oldName is the same as newName… #40

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

JacobZyy
Copy link

@JacobZyy JacobZyy commented Apr 28, 2024

#39

add a compare of oldName and newName on the start of the rename()
if they are the same , return false ( Should this rename be considered failed? )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant