Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add platform specific GPS/Baro weight in defaults #1973

Open
wants to merge 47 commits into
base: master
Choose a base branch
from

Conversation

MrD-RC
Copy link
Collaborator

@MrD-RC MrD-RC commented Feb 20, 2024

Specific settings for inav_w_z_baro_p, inav_w_z_gps_p, and inav_w_z_gps_v for multirotors and fixed wing.

@MrD-RC MrD-RC added this to the 7.1 milestone Feb 20, 2024
@mmosca
Copy link
Collaborator

mmosca commented Feb 20, 2024

I am not convinced we need the profile changes. We reverted to better behaving defaults and in 8.0, with the baro filtering changes and potential gps weight adjustments by hdop, the defaults will be good enough. If we still think users will be changing these often, they should be somewhere in the configurator instead.

@DzikuVx
Copy link
Member

DzikuVx commented Feb 21, 2024

I think users should not be changing those. It's complex already and let's not make it more complex tha before.

@MrD-RC
Copy link
Collaborator Author

MrD-RC commented Feb 21, 2024

The thought behind this is not users changing the values. It's because the values seem to be different for FW and MR. I just made this PR as an option.

@DzikuVx DzikuVx modified the milestones: 7.1, 8.0 Mar 7, 2024
@DzikuVx DzikuVx changed the base branch from release_7.1.0 to master March 7, 2024 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants