Remove pledge() support for OpenBSD #6048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While this initially worked fine, at some point these patches broke because libcairo started calling shmget(2) - a syscall not covered by any pledge promise - and a common pitfall when using pledge with graphics-oriented applications. Various attempts were made to fix them, but at some time they were simply disabled in the OpenBSD port: openbsd/ports@a4a9f41 openbsd/ports@5a03c38 This seems pointless and creates needless friction both for the i3 team who was willing to carry ugly code and for the OpenBSD ports maintainers who had to disable that code again. Let's abandon this experiment.
orestisfl
approved these changes
May 17, 2024
|
Thank you for the PR & elaborate context. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While this initially worked fine, at some point these patches broke because libcairo started calling shmget(2) - a syscall not covered by any pledge promise - and a common pitfall when using pledge with graphics-oriented applications.
Various attempts were made to fix them, but at some time they were simply disabled in the OpenBSD port:
openbsd/ports@a4a9f41 openbsd/ports@5a03c38
This seems pointless and creates needless friction both for the i3 team who was willing to carry ugly code and for the OpenBSD ports maintainers who had to disable that code again.
Let's abandon this experiment.