checkout: Allow fully discounted carts to be placed.

[C4rter]

Before, payment was always required even if the grand total of a cart was zero.
Now, when no payment is required the order is being placed without payment processing.
In the checkoutform, no payment selection is set in this case.

• Add changelog
• Fix float comparison issues (currently tests are failing)
• Move some code in tests to helper functions
• Move coupon logic from inmemory cart to integration test layer
• Check new standard place order

[zohmi]

Would be nice to start with some tests for the checkoutcontroller.

[danielpoe]

Would be nice to start with some tests for the checkoutcontroller.

If we start this we should do black box functional test and avoid mocking all dependencies of the controller imho.

[carstendietrich]

@danielpoe is the in memory cart intended to be used in a production shop? I added a 100% discount voucher to be able to test our changes here.. would duplicate the in memory adapter to the integration test project if needed..

[danielpoe]

@danielpoe is the in memory cart intended to be used in a production shop? I added a 100% discount voucher to be able to test our changes here.. would duplicate the in memory adapter to the integration test project if needed..

Its not ready yet but I think we should have this in mind:

• probably the cartstorage should be exchangeable in future (to work in cluster - e.g. with redis)
• the supported coupons could also be configured then - maybe we add an optional cartVoucherCodeEvaluation interface that you can inject in the integrationtests with your testdata?

[carstendietrich]

@danielpoe is the in memory cart intended to be used in a production shop? I added a 100% discount voucher to be able to test our changes here.. would duplicate the in memory adapter to the integration test project if needed..

Its not ready yet but I think we should have this in mind:

• probably the cartstorage should be exchangeable in future (to work in cluster - e.g. with redis)
• the supported coupons could also be configured then - maybe we add an optional cartVoucherCodeEvaluation interface that you can inject in the integrationtests with your testdata?

Okay for the first step we'll add the possibility of the cartVoucherCodeEvaluation to the in memory behaviour. For supporting redis cart storage I'll add an issue (see #199).

Currently we are also facing float rounding issues so cart.GrandTotal().IsZero() doesn't work always. See randomly failing tests.

[carstendietrich]

@danielpoe we added a GiftCardHandler and VoucherHandler interface so that we are able to use the InMemory Cart with project / test specific voucher / gift card handling. You may have a look :)

[danielpoe]

Awesome :-)

[zohmi]

Thanks for contributing :) Only left some minor feedback