-
-
Notifications
You must be signed in to change notification settings - Fork 718
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
xwayland: allow to disable xwayland via config option #3371
base: main
Are you sure you want to change the base?
Conversation
so it just adds an option but that option aint doing nothin'? |
By default yes nothing will happen, because by default xwayland is enabled. If you add:
Then it wont spawn xwayland. |
based on the diff I'd like to contest that statement |
lol the other file hasnt been added |
well, add it then maybe? :) |
d14d9b3
to
e15a7b6
Compare
yeah already pushed. sry haha |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
outside of this, since xwayland runs in parallel, you'll need to add a function (probably in the config manager) to check the status of xwayland on config reloads.
if someone edits the option, we might want to kill / start xwayland
well I'd rather restrict editing that option. It should be initiated just once in the lifetime of the program |
this is absolutely wrong, as xwayland will naturally be shut down if no xwayland apps are open, anyways (lazy mode in hyprland is always on) |
e15a7b6
to
32f1d7f
Compare
the intention for it is to force everything to native wayland. in lazy mode it will still launch as x11 app if broken detection with happened for it to fallback to xorg, etc |
yes, but what I want is for people to be able to dynamically toggle xwayland on / off. As in, if xwayland is enabled and there are xwayland apps open, and someone disables it, kill xwayland.
that is done by |
well yeah I can look into that |
32f1d7f
to
b7f33ca
Compare
You don’t need any extra parameters, you can do this and xwayland won’t start.
|
bb93090
to
3a189c2
Compare
7110a04
to
25aec3a
Compare
Adds ability to disable xwayland without recompilation with the flag