Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Refactor Sonarqube & DefectDojo job #4605

Merged

Conversation

BAStos525
Copy link
Member

@BAStos525 BAStos525 commented May 16, 2024

Description

  1. Move workspace_analysis, with_coverage and sonarqube-defectdojo jobs to the new dedicated workflow.
  2. Change docker registries repo for iroha2:dev and iroha2-nightly images.

Linked issue

#4510 #4598

Closes

(should): #4510 #4598

Benefits

Fix clippy and lcov reports uploading to Sonarqube and DefectDojo.

Checklist

  • I've read CONTRIBUTING.md
  • I've used the standard signed-off commit format (or will squash just before merging)
  • All applicable CI checks pass (or I promised to make them pass later)
  • (optional) I've written unit tests for the code changes
  • I replied to all comments after code review, marking all implemented changes with thumbs up

@BAStos525
Copy link
Member Author

@0x009922 please help to update docker-compose swarm regarding new dev image path

@BAStos525 BAStos525 changed the title [ci] #4510 #4598: Refactor Sonarqube & DefectDojo job [ci]: Refactor Sonarqube & DefectDojo job May 16, 2024
@BAStos525 BAStos525 force-pushed the fix/dops-3186/i2-refactor-sonar-dojo branch 2 times, most recently from e7b6079 to 15ae524 Compare May 16, 2024 15:38
@BAStos525 BAStos525 changed the title [ci]: Refactor Sonarqube & DefectDojo job ci: Refactor Sonarqube & DefectDojo job May 16, 2024
nxsaken
nxsaken previously approved these changes May 17, 2024
@nxsaken nxsaken removed the iroha2 label May 17, 2024
@nxsaken
Copy link
Contributor

nxsaken commented May 21, 2024

@BAStos525 can you amend my latest commit to include the sign-off? Turns out GH's inconsistent when signing off commits created from the web UI.

@BAStos525 BAStos525 force-pushed the fix/dops-3186/i2-refactor-sonar-dojo branch from e983209 to c1099d6 Compare May 21, 2024 07:20
@nxsaken nxsaken merged commit 89e445b into hyperledger:main May 21, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants