Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Add torii api tests #4564

Merged
merged 4 commits into from
May 23, 2024
Merged

test: Add torii api tests #4564

merged 4 commits into from
May 23, 2024

Conversation

AlexStroke
Copy link
Contributor

@AlexStroke AlexStroke commented May 7, 2024 •
edited

Description

Linked issue

Closes #4563

Benefits

Checklist

  • I've read CONTRIBUTING.md
  • I've used the standard signed-off commit format (or will squash just before merging)
  • All applicable CI checks pass (or I promised to make them pass later)
  • (optional) I've written unit tests for the code changes
  • I replied to all comments after code review, marking all implemented changes with thumbs up

@AlexStroke AlexStroke changed the title feature: add troii api tests test: add troii api tests May 7, 2024
@AlexStroke AlexStroke changed the title test: add troii api tests test: Add torii api tests May 7, 2024
@AlexStroke AlexStroke force-pushed the torii-api-tests branch 12 times, most recently from f7b7f7e to b9fb969 Compare May 14, 2024 13:47
@AlexStroke AlexStroke marked this pull request as ready for review May 14, 2024 16:21
0x009922
0x009922 reviewed May 15, 2024
View reviewed changes
torii/pytests/common/schemas/get_schema_response.json Outdated Show resolved Hide resolved
torii/pytests/.idea/.gitignore Outdated Show resolved Hide resolved
torii/pytests/test/health/test_health.py Outdated Show resolved Hide resolved
torii/pytests/test/health/test_health.py Outdated Show resolved Hide resolved
@0x009922 0x009922 self-assigned this May 15, 2024
@AlexStroke AlexStroke force-pushed the torii-api-tests branch 5 times, most recently from e11d7e3 to b5b376f Compare May 21, 2024 09:34
nxsaken
nxsaken reviewed May 21, 2024
View reviewed changes
.github/ISSUE_TEMPLATE/bug.yml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/bug.yml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/bug.yml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/bug.yml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/bug.yml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/bug.yml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/bug.yml Outdated Show resolved Hide resolved
@nxsaken nxsaken mentioned this pull request May 22, 2024
Merged
5 tasks
@AlexStroke AlexStroke force-pushed the torii-api-tests branch 5 times, most recently from 0abbcd2 to 05b51f5 Compare May 22, 2024 12:49
@AlexStroke
test: add linters
7375ca3 
Signed-off-by: alexstroke <[email protected]>
0x009922
0x009922 approved these changes May 23, 2024
View reviewed changes
Copy link
Contributor

@0x009922 0x009922 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlexStroke AlexStroke merged commit fad3e0c into hyperledger:main May 23, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nxsaken nxsaken nxsaken left review comments

@0x009922 0x009922 0x009922 approved these changes

@BAStos525 BAStos525 BAStos525 approved these changes

@s8sato s8sato Awaiting requested review from s8sato s8sato is a code owner

@mversic mversic Awaiting requested review from mversic mversic is a code owner

@SamHSmith SamHSmith Awaiting requested review from SamHSmith SamHSmith is a code owner

@outoftardis outoftardis Awaiting requested review from outoftardis outoftardis is a code owner

@Erigara Erigara Awaiting requested review from Erigara Erigara is a code owner

@DCNick3 DCNick3 Awaiting requested review from DCNick3 DCNick3 is a code owner

@VAmuzing VAmuzing Awaiting requested review from VAmuzing VAmuzing is a code owner

@Asem-Abdelhady Asem-Abdelhady Awaiting requested review from Asem-Abdelhady

@dima74 dima74 Awaiting requested review from dima74 dima74 is a code owner

Assignees

@0x009922 0x009922

@BAStos525 BAStos525

@AlexStroke AlexStroke

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Integrate Torii API tests into the main repo and CI
4 participants
@AlexStroke @nxsaken @0x009922 @BAStos525