fix: Don't prematurely execute time-triggers before their start
timestamp
#4333
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While original issues doesn't state it clearly I think that the problem was premature execution of time triggers.
So that trigger could be executed even before
start
. I fixed this.start
point beforelatest_block_timestamp + consensus_estimation
time, whereconsensus_estimation = 4 secs
and is a hardcoded constant. Everithing before this timestamp is considered already analyzed by Iroha. In other words -- time-triggers in the past are forbidden.start
point is in futurechange_asset_metadata_after_1_sec
testForbidding time-triggers in the past was the simpliest solution and I actually think it was making sence to implement that in the initial solution.
Linked issue
Benefits
Checklist
CONTRIBUTING.md