Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[suggestion] Time trigger first execution time #3262

Closed
appetrosyan opened this issue Feb 28, 2023 · 0 comments · Fixed by #4333
Closed

[suggestion] Time trigger first execution time #3262

appetrosyan opened this issue Feb 28, 2023 · 0 comments · Fixed by #4333
Assignees
@Erigara @mversic
Labels
Enhancement New feature or request iroha2-dev The re-implementation of a BFT hyperledger in RUST

Comments

@appetrosyan
Copy link
Contributor

Feature request

We want to execute the time trigger in the first block that comes after start but before the start+period time.

Motivation

@arndey Detected that the current implementation is somewhat misleading. As we want for our triggers to be final and stable we want to fix the implemetation sooner rather than later.

Who can help?

@appetrosyan @Arjentix @arndey
@appetrosyan appetrosyan added Enhancement New feature or request iroha2-dev The re-implementation of a BFT hyperledger in RUST labels Feb 28, 2023
@appetrosyan appetrosyan self-assigned this Feb 28, 2023
@Arjentix Arjentix self-assigned this Feb 21, 2024
Arjentix added a commit to Arjentix/iroha that referenced this issue Feb 27, 2024
@Arjentix
[fix] hyperledger#3262: Don't prematurely execute time-triggers
ff6b8ac 
Signed-off-by: Daniil Polyakov <[email protected]>
@Arjentix Arjentix mentioned this issue Feb 27, 2024
Merged
5 tasks
Arjentix added a commit to Arjentix/iroha that referenced this issue Feb 27, 2024
@Arjentix
[fix] hyperledger#3262: Don't prematurely execute time-triggers befor…
160c838 
…e their `start` timestamp

Signed-off-by: Daniil Polyakov <[email protected]>
@mversic mversic self-assigned this Mar 27, 2024
@Erigara Erigara self-assigned this May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Erigara Erigara

@mversic mversic

Labels
Enhancement New feature or request iroha2-dev The re-implementation of a BFT hyperledger in RUST
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Don't prematurely execute time-triggers before their start timestamp Arjentix/iroha
4 participants
@appetrosyan @Arjentix @Erigara @mversic