Add multiparty status API #1509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chris Bygrave <[email protected]>
chrisbygrave
force-pushed
the
multiparty-status
branch
from
9893ea7
to
9781943
Compare
Signed-off-by: Chris Bygrave <[email protected]>
Signed-off-by: Chris Bygrave <[email protected]>
chrisbygrave
force-pushed
the
multiparty-status
branch
from
fd0e3a7
to
cafe959
Compare
Signed-off-by: Chris Bygrave <[email protected]>
chrisbygrave
force-pushed
the
multiparty-status
branch
from
e362c16
to
1a71db6
Compare
- derived from catchup Signed-off-by: Chris Bygrave <[email protected]>
Signed-off-by: Chris Bygrave <[email protected]>
awrichar
reviewed
May 21, 2024
awrichar
reviewed
May 21, 2024
awrichar
reviewed
May 21, 2024
| } | ||
|
|
||
| // Ensure the given registration message correlates with the expected type | ||
| func (or *orchestrator) checkRegistrationType(ctx context.Context, msg *core.MessageInOut, expectedType core.IdentityType) (match bool, err error) { |
There was a problem hiding this comment.
Was this check in response to a specific error scenario we've seen? I'm trying to think why there would be a pending registration message, but the contents would be inconsistent.
There was a problem hiding this comment.
No, it was purely theoretical - it felt clumsy before I added this that we would find a registration message and just assume it was of the correct type. It's technically possible that a pending node registration message could be there without the org being registered, and the API would then return the wrong response.
I admit it could be overkill...
awrichar
reviewed
May 21, 2024
- also added a missing test around retrieving active listener status Signed-off-by: Chris Bygrave <[email protected]>
awrichar
approved these changes
May 23, 2024
Signed-off-by: Chris Bygrave <[email protected]>
Signed-off-by: Chris Bygrave <[email protected]>
Signed-off-by: Chris Bygrave <[email protected]>
EnriqueL8
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.