Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating in Mapping #18

Merged
merged 2 commits into from
May 29, 2024
Merged

Conversation

VictorH2208
Copy link
Contributor

This PR updates the mapping functions of both credential and presentation. To see how it works, can run the unit test at the end of the each files. Or run cargo test test_to_anoncreds_presentation for the presentation procedure or cargo test test_to_w3c for credentials. The output files can be found in the "samples" folder. The file "w3c_presentation" is the output of converting from AnonCreds to W3C, the "anoncreds_output" is the output of converting back to AnonCreds, and the "anoncreds_presentation_list" is the input that contains the presentation proof, schema and nonce used.

Signed-off-by: VictorH2208 <[email protected]>
@swcurran
Copy link
Member

@mikelodder7 — can you please take a look? This was discussed at the 2024025 AnonCreds Working Group meeting — recording here — and there are some questions for you.

@VictorH2208 — can you please take a look at addressing the lint issues in the failed test above? It looks like a lot, but I think most of them will be easy to address.

@VictorH2208
Copy link
Contributor Author

@mikelodder7 — can you please take a look? This was discussed at the 2024025 AnonCreds Working Group meeting — recording here — and there are some questions for you.

@VictorH2208 — can you please take a look at addressing the lint issues in the failed test above? It looks like a lot, but I think most of them will be easy to address.

Yep. Looking at them right now.

Signed-off-by: VictorH2208 <[email protected]>
Copy link
Contributor

@mikelodder7 mikelodder7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add an explainer to this? For future PR. This is hard to follow without one and there’s no explanation for the constants about where they come from and why they’re needed.

@mikelodder7 mikelodder7 merged commit 47a6224 into hyperledger:main May 29, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants