Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added new adaptor to allow for multiple joysticks #715

Draft
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

spacemandev-git
Copy link

current adapter hard coded loading only the first joystick. added a new adapter that would allow for arbitrary joysticks based on id

@deadprogram deadprogram changed the base branch from master to dev January 11, 2020 18:10
@deadprogram
Copy link
Member

Hello @brownie79 first of all, thanks for your contribution.

I changed the branch on the PR to dev as documented here: https://github.com/hybridgroup/gobot/blob/master/CONTRIBUTING.md#general-guidelines

We also just merged a fix for the Travis build problems, unrelated to your PR.

Could you please rebase your PR against the dev branch and push again?

Thank you!

@gen2thomas
Copy link
Collaborator

gen2thomas commented Sep 19, 2022

Meanwhile there is another PR available for the same feature: #732 . It looks quite similar, but has the following advantages IMO:

  • compute the err-code of "sdl.Init()"
  • use the name instead of ID is more user friendly
  • add just the first device if there are more than once (with the same name)

Because the "usage of name is an advantage" is just my feeling, I referenced the existing issue #564 to collect some requirements and add both PR's as reference.

@gen2thomas
Copy link
Collaborator

Set this PR back to draft as reference of a new/improved implementation.

@gen2thomas gen2thomas marked this pull request as draft October 20, 2022 11:41
@gedw99
Copy link

gedw99 commented Mar 11, 2023

Hey @gen2thomas

I am adding stadia gamepad, so let me know if i can help with this PR etc.

@gen2thomas gen2thomas deleted the branch hybridgroup:dev May 15, 2023 16:25
@gen2thomas gen2thomas closed this May 15, 2023
@gen2thomas
Copy link
Collaborator

accidentally closed - now reopen

@gen2thomas gen2thomas reopened this May 23, 2023
@gen2thomas gen2thomas added the maintainer wanted the implementation was started, but for some reason not finished label Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintainer wanted the implementation was started, but for some reason not finished
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants