[locale-fr] Fixed typo, added tests #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
nice work, I have change the locale test file here and can run it with |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#19 I had left a single quote (') in a translation string. It's now fixed.
Also I took the tests for locale zn_CH from test.js and put them in a new file called fr-localeTest.js. I didn't reinclude all the tests for locale en as they are already in test.js. Feel free to do something different if you feel like it's better!
PS: Sorry for breaking your code with my original translation ^^
Also, please note I did not run the tests as I do not have an environment for JS dev.