Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(feat) add limit maker order to order type map #7030

Merged
merged 2 commits into from
May 16, 2024

Conversation

cardosofede
Copy link
Contributor

Before submitting this PR, please make sure:

  • Your code builds clean without any errors or warnings
  • You are using approved title ("feat/", "fix/", "docs/", "refactor/")

A description of the changes proposed in the pull request:
This PR solves the issue described in #7019 for OKX Spot and OKX Perpetual

Tests performed by the developer:

Tips for QA testing:

@cardosofede cardosofede marked this pull request as ready for review May 16, 2024 16:00
Copy link
Contributor

@nikspz nikspz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test performed:

  • Cloned and installed PR7030
  • Connected okx spot and perpetual succesfully
  • Review orders now placed for PureMM and perpetualMM

image

@nikspz nikspz merged commit 489601a into hummingbot:development May 16, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Release version 1.28.0
Development

Successfully merging this pull request may close these issues.

None yet

2 participants