update: gdb logging enable/disable command

[mtwoz]

'set logging on/off' is deprecated and replaced with 'set logging enabled on/off'.

Description

• My code follows the code style of this project.
• My change includes a change to the documentation, if required.
• If my change adds new code, adequate tests have been added.
• I have read and agree to the CONTRIBUTING document.

[github-actions]

🤖 Coverage update for 1930e8d 🟢

	Old	New
Commit	92f45ba	1930e8d
Score	71.5835%	71.5835% (0)

[hugsy]

Do you happen to know in which version this deprecation occured?

Update: it seems to have appeared somewhere between v9 (doesn't work) and v12 (works).
So just to ensure retro-compatibility, please update your PR by checking the version against GDB_VERSION

[mtwoz]

Do you happen to know in which version this deprecation occured?

Update: it seems to have appeared somewhere between v9 (doesn't work) and v12 (works). So just to ensure retro-compatibility, please update your PR by checking the version against GDB_VERSION

Thanks for reminding me. So do I need to add an if judgment to choose to use 'set logging on/off' or 'set logging enabled on/off' based on GDB_VERSION?

[hugsy]

Thanks for reminding me. So do I need to add an if judgment to choose to use 'set logging on/off' or 'set logging enabled on/off' based on GDB_VERSION?

From the docs it seems that set logging enabled on/off is the way going forward so yes, it is better to simply add a if GDB_VERSION > check until our base version supported becomes one where set logging enabled on/off always works

[github-actions]

🤖 Coverage update for b5ffba9 🟢

	Old	New
Commit	18c1f7c	b5ffba9
Score	71.5629%	71.5629% (0)

[github-actions]

🤖 Coverage update for 9a14dcf 🟢

	Old	New
Commit	18c1f7c	9a14dcf
Score	71.5629%	71.5629% (0)

[mtwoz]

Thanks for reminding me. So do I need to add an if judgment to choose to use 'set logging on/off' or 'set logging enabled on/off' based on GDB_VERSION?

From the docs it seems that set logging enabled on/off is the way going forward so yes, it is better to simply add a if GDB_VERSION > check until our base version supported becomes one where set logging enabled on/off always works

Hi, I just added those judgments mentioned above.

[hugsy]

@mtwoz Code formatting fails. Please fix and re-submit. Once it passes it can be merged.

[mtwoz]

@mtwoz Code formatting fails. Please fix and re-submit. Once it passes it can be merged.

OK. Thanks. I just fixed it.

[github-actions]

🤖 Coverage update for d5e460d 🟢

	Old	New
Commit	18c1f7c	d5e460d
Score	71.5629%	71.5629% (0)

[hugsy]

LGTM