Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removal of deprecated maps #30576

Merged
merged 4 commits into from May 9, 2024
Merged

Removal of deprecated maps #30576

merged 4 commits into from May 9, 2024

Conversation

LysandreJik
Copy link
Member

No description provided.

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Remove remaining ARCHIVE MAPS

Remove remaining PRETRAINED maps
Copy link
Collaborator

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM maybe just the 3 tests need to use from_pretrained_id?

class DonutProcessorTest(unittest.TestCase):
def setUp(self):
self.processor = DonutProcessor.from_pretrained(DONUT_PRETRAINED_MODEL_NAME)
self.processor = DonutProcessor.from_pretrained("naver-clova-ix/donut-base")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for this one an dthe 3 others we don't use self.from_pretrained_id ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah yes woops thanks!

@ArthurZucker ArthurZucker marked this pull request as ready for review May 6, 2024 08:43
@LysandreJik LysandreJik merged commit 297b732 into main May 9, 2024
21 of 23 checks passed
@LysandreJik LysandreJik deleted the remove-deprecated-maps branch May 9, 2024 12:15
zucchini-nlp pushed a commit to zucchini-nlp/transformers that referenced this pull request May 10, 2024
* [test_all] Remove all imports

Remove remaining ARCHIVE MAPS

Remove remaining PRETRAINED maps

* review comments

* [test_all] empty commit to trigger tests
itazap pushed a commit that referenced this pull request May 14, 2024
* [test_all] Remove all imports

Remove remaining ARCHIVE MAPS

Remove remaining PRETRAINED maps

* review comments

* [test_all] empty commit to trigger tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants