Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:missing output_router_logits in SwitchTransformers #30573

Merged
merged 2 commits into from May 2, 2024

Conversation

lausannel
Copy link
Contributor

@lausannel lausannel commented Apr 30, 2024

What does this PR do?

Fixes # (issue)

Before submitting

  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.

Please refer to issue #30571

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@ArthurZucker

@amyeroberts
Copy link
Collaborator

cc @ArthurZucker @younesbelkada

Copy link
Contributor

@younesbelkada younesbelkada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thanks !

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@lausannel
Copy link
Contributor Author

lausannel commented May 1, 2024

Hi @younesbelkada, @amyeroberts, could you please review if this PR is ready for merging? If everything is in order, could you merge it? Thank you for your time!

Copy link
Collaborator

@amyeroberts amyeroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@younesbelkada younesbelkada merged commit a65da83 into huggingface:main May 2, 2024
20 checks passed
itazap pushed a commit that referenced this pull request May 14, 2024
* fix:missing `output_router_logits` in SwitchTransformers

* fix whitespace in blank line
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants