Issue#28224 fix a link in doc #30562
Open
+5
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The link pointing to additional documentation for additional keyword arguments that pass along to the generate method of the model was incorrect which has been addressed in this commit.
- The link pointing to additional documentation for additional keyword arguments that pass along to the generate method of the model was incorrect which has been addressed in this commit.
…uthusamy/transformers into issue#28224-fix-a-link-in-doc
4 tasks
|
cc @gante |
stevhliu
reviewed
Apr 30, 2024
| @@ -270,7 +270,7 @@ def __call__(self, conversations: Union[List[Dict], Conversation, List[Conversat | |||
| Whether or not to clean up the potential extra spaces in the text output. | |||
| generate_kwargs: | |||
| Additional keyword arguments to pass along to the generate method of the model (see the generate method | |||
| corresponding to your framework [here](./model#generative-models)). | |||
| corresponding to your framework [here](https://huggingface.co/docs/transformers/generation_strategies#text-generation-strategies)). | |||
There was a problem hiding this comment.
I think it'd be better to link to the Generation API doc since that has the specific keyword arguments for each framework whereas the Text generation strategies doc has a wider scope.
|
@nmuthusamy are you planning on further working on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes a documentation link in pipeline docs. The link pointing to additional documentation for additional keyword arguments that pass along to the generate method of the model was incorrect which has been addressed in this PR.
Fixes # (issue)
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.