Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TGI monitoring guide through Grafana and Prometheus #1908

Merged
merged 3 commits into from
May 17, 2024

Conversation

fxmarty
Copy link
Collaborator

@fxmarty fxmarty commented May 16, 2024

As per title. It is very useful.

@fxmarty fxmarty requested review from Narsil and drbh May 16, 2024 13:41
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Collaborator

@Narsil Narsil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks A LOT for this.

IMHO the screenshot should be very high up in the README page.

drbh
drbh previously approved these changes May 16, 2024
Copy link
Collaborator

@drbh drbh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you! this is super helpful.

nit: I agree a screenshot with more metrics/graphs on the top of the docs would look best

@fxmarty
Copy link
Collaborator Author

fxmarty commented May 17, 2024

@Narsil @drbh I lost the approval.

I updated the image and the recommended JSON, it's very nice, thank you! https://moon-ci-docs.huggingface.co/docs/text-generation-inference/pr_1908/en/basic_tutorials/monitoring

Copy link
Collaborator

@drbh drbh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great! thank @fxmarty!

@drbh drbh merged commit c4cf8b4 into main May 17, 2024
2 checks passed
@drbh drbh deleted the prometheus-grafana-guide branch May 17, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants