Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mamba enablement #987

Open
wants to merge 4 commits into
base: transformers_4.40
Choose a base branch
from
Open

Mamba enablement #987

wants to merge 4 commits into from

Conversation

libinta
Copy link
Collaborator

@libinta libinta commented May 16, 2024

What does this PR do?

Initial emblement for mamba with static shape.

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?

@libinta libinta added the run-test Run CI for PRs from external contributors label May 23, 2024
@regisss regisss changed the title Mamaba enablement Mamba enablement May 24, 2024
regisss
regisss reviewed May 24, 2024
View reviewed changes
Copy link
Collaborator

@regisss regisss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add a test in test_text_generation.py too no?

optimum/habana/transformers/models/mamba/modeling_mamba.py Show resolved Hide resolved
@libinta libinta removed the run-test Run CI for PRs from external contributors label May 28, 2024
MohitIntel
MohitIntel reviewed Jun 17, 2024
View reviewed changes
tests/resource/image-captioning-example.png
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this file was moved to img folder in the latest commit on trasnformers_4.40 branch.

@MohitIntel
Copy link
Collaborator

Let's add a test in test_text_generation.py too no?

Added in latest commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@regisss regisss regisss left review comments

@MohitIntel MohitIntel MohitIntel left review comments

@ssarkar2 ssarkar2 Awaiting requested review from ssarkar2 ssarkar2 is a code owner

@bhargaveede bhargaveede Awaiting requested review from bhargaveede bhargaveede is a code owner

@vivekgoe vivekgoe Awaiting requested review from vivekgoe vivekgoe is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@libinta @MohitIntel @regisss