Enabled DETR (Object Detection) model #1046
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cfgfung can you rebase the PR? |
cfgfung
force-pushed
the
examples/detr_resnet
branch
from
b26d202
to
5dddd9e
Compare
Hi,
|
imangohari1
suggested changes
Jun 27, 2024
There was a problem hiding this comment.
Hi @cfgfung
thank you for the work here.
Below are my suggestions for this PR. Let's work on these and do a final review.
- I've made some changes regarding some minor clean ups and ci tests. Please review and implement them via
git am < 0001*(file attached). - Few minor comments are give in comment.
0001-fea-Minor-CI-updates-and-clean-ups.patch
G2 results (after applying the patch)
---------------------------: System Configuration :---------------------------
Num CPU Cores : 160
CPU RAM : 1056375224 KB
------------------------------------------------------------------------------
Detected cat with confidence 1.0 at location [344.0, 25.25, 640.0, 376.0]
Detected remote with confidence 0.996 at location [328.0, 75.5, 372.0, 188.0]
Detected remote with confidence 0.996 at location [39.0, 70.5, 176.0, 118.0]
Detected cat with confidence 1.0 at location [15.62, 52.5, 316.0, 472.0]
Detected couch with confidence 0.996 at location [-1.25, 0.94, 640.0, 472.0]
Stats:
------------------------------------------------------------
Total latency (ms): 58.38346481323242 (for n_iterations=10)
Average latency (ms): 5.838346481323242 (per iteration)
------------------------------------------------------------
imangohari1
reviewed
Jun 27, 2024
| # Run unit and integration tests related to Image segmentation | ||
| fast_tests_object_detection: | ||
| python -m pip install .[tests] | ||
| python -m pip install timm |
There was a problem hiding this comment.
if no_timm is used for the test, is this needed?
|
|
||
| adapt_transformers_to_gaudi() | ||
|
|
||
| # you can specify the revision tag if you don't want the timm dependency |
There was a problem hiding this comment.
not sure how to approach this here, but would be nice to able to pass/toggle between no_timm and main revisions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR contains the patch, example, and test codes for DETR models.
A100 CUDA BF16(Autocast) benchmarks:
n_iterations: 10
Total latency (ms): 241.29199981689453
Average latency (ms): 24.129199981689453
Gaudi2 BF16(Autocast and Graph mode) benchmarks:
n_iterations: 10
Total latency (ms): 65.3073787689209
Average latency (ms): 6.53073787689209
Before submitting