Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add no_checks for sub dataset in lvwerra/stack-exchange-paired since … #1003

Merged
merged 3 commits into from
Jun 5, 2024

Conversation

sywangyi
Copy link
Collaborator

…it does not contain test split

What does this PR do?

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?

…it does not contain test split

Signed-off-by: Wang, Yi A <[email protected]>
@sywangyi sywangyi requested a review from regisss as a code owner May 23, 2024 06:21
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@sywangyi
Copy link
Collaborator Author

load dataset error if datasets >= 2.19.0.
error is like
image

@sywangyi
Copy link
Collaborator Author

occurred after huggingface/datasets#6714 is merged.

@sywangyi
Copy link
Collaborator Author

same fix in trl huggingface/trl#1670

@regisss
Copy link
Collaborator

regisss commented Jun 4, 2024

@sywangyi Could you try with the latest release of Datasets (v2.19.2) please? It should solve this issue, i.e. no need for verification_mode="no_checks" anymore.

@sywangyi
Copy link
Collaborator Author

sywangyi commented Jun 4, 2024

yes. works in 2.19.2

@regisss
Copy link
Collaborator

regisss commented Jun 4, 2024

yes. works in 2.19.2

Great! Could you remove verification_mode="no_checks" from the examples (dpo.py too) and set the requirements datasets==2.19.2 in requirements.txt please?

@sywangyi
Copy link
Collaborator Author

sywangyi commented Jun 4, 2024

ok, I will do it

Signed-off-by: Wang, Yi A <[email protected]>
@regisss regisss merged commit 1911dc6 into main Jun 5, 2024
9 checks passed
@regisss regisss deleted the no_check branch June 5, 2024 20:25
imangohari1 pushed a commit to imangohari1/optimum-habana that referenced this pull request Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants