Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌐 [i18n-KO] Translated guides/integrations.md to Korean #2256

Merged
merged 22 commits into from
Jun 13, 2024

Conversation

cjfghk5697
Copy link
Contributor

@cjfghk5697 cjfghk5697 commented Apr 29, 2024

What does this PR do?

Translated the guides/integrations.md file of the documentation to Korean.
Thank you in advance for your review.

Part of #1626

Before reviewing

  • Check for missing / redundant translations (번역 누락/중복 검사)
  • Grammar Check (맞춤법 검사)
  • Review or Add new terms to glossary (용어 확인 및 추가)
  • Check Inline TOC (e.g. [[lowercased-header]])
  • Check live-preview for gotchas (live-preview로 정상작동 확인)

Who can review? (Initial)

Team Hugging Face KREW, may you please review this PR?
@harheem, @cjfghk5697, @seoulsky-field, @nuatmochoi, @boyunJang, @SeungAhSon, @seoyoung-3060, @junejae, @usr-bin-ksh, @fabxoe

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review? (Final)

@jungnerd, @heuristicwave May you please review this PR?

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

docs/source/ko/guides/integrations.md Outdated Show resolved Hide resolved
docs/source/ko/guides/integrations.md Outdated Show resolved Hide resolved
docs/source/ko/guides/integrations.md Outdated Show resolved Hide resolved
docs/source/ko/guides/integrations.md Outdated Show resolved Hide resolved
docs/source/ko/guides/integrations.md Outdated Show resolved Hide resolved
Copy link
Contributor

@usr-bin-ksh usr-bin-ksh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

어색한 문장과 원문과비교해서 빠진것 같은부분을 조금 추가해봤습니다,,

docs/source/ko/guides/integrations.md Outdated Show resolved Hide resolved
docs/source/ko/guides/integrations.md Outdated Show resolved Hide resolved
docs/source/ko/guides/integrations.md Outdated Show resolved Hide resolved
docs/source/ko/guides/integrations.md Outdated Show resolved Hide resolved
docs/source/ko/guides/integrations.md Outdated Show resolved Hide resolved
docs/source/ko/guides/integrations.md Outdated Show resolved Hide resolved
docs/source/ko/guides/integrations.md Outdated Show resolved Hide resolved
docs/source/ko/guides/integrations.md Outdated Show resolved Hide resolved
docs/source/ko/guides/integrations.md Outdated Show resolved Hide resolved
docs/source/ko/guides/integrations.md Outdated Show resolved Hide resolved
docs/source/ko/guides/integrations.md Outdated Show resolved Hide resolved
docs/source/ko/guides/integrations.md Outdated Show resolved Hide resolved
docs/source/ko/guides/integrations.md Outdated Show resolved Hide resolved
docs/source/ko/guides/integrations.md Outdated Show resolved Hide resolved
docs/source/ko/guides/integrations.md Outdated Show resolved Hide resolved
docs/source/ko/guides/integrations.md Outdated Show resolved Hide resolved
Co-authored-by: usr/bin/ksh <[email protected]>
Co-authored-by: SeongWooChoi <[email protected]>
docs/source/ko/guides/integrations.md Outdated Show resolved Hide resolved
docs/source/ko/guides/integrations.md Outdated Show resolved Hide resolved
docs/source/ko/guides/integrations.md Outdated Show resolved Hide resolved
docs/source/ko/guides/integrations.md Outdated Show resolved Hide resolved
docs/source/ko/guides/integrations.md Outdated Show resolved Hide resolved
docs/source/ko/guides/integrations.md Outdated Show resolved Hide resolved
@cjfghk5697 cjfghk5697 marked this pull request as ready for review May 22, 2024 12:13
Copy link
Contributor

@nuatmochoi nuatmochoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

표 안의 내용도 번역하면 좋을 것 같아 번역해보았습니다.

docs/source/ko/guides/integrations.md Outdated Show resolved Hide resolved
docs/source/ko/guides/integrations.md Outdated Show resolved Hide resolved
docs/source/ko/guides/integrations.md Outdated Show resolved Hide resolved
docs/source/ko/guides/integrations.md Outdated Show resolved Hide resolved
docs/source/ko/guides/integrations.md Outdated Show resolved Hide resolved
docs/source/ko/guides/integrations.md Outdated Show resolved Hide resolved
docs/source/ko/guides/integrations.md Outdated Show resolved Hide resolved
Co-authored-by: Jihun Lim <[email protected]>
Co-authored-by: SeongWooChoi <[email protected]>
@cjfghk5697
Copy link
Contributor Author

리뷰 도와주신분들 너무 감사합니다.. 계속 다시 확인해도 오류가 나오네요.. 다시 한번 감사합니다!!

Copy link

@swadhinbiswas swadhinbiswas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

다 괜찮아

docs/source/ko/guides/integrations.md Outdated Show resolved Hide resolved
docs/source/ko/guides/integrations.md Outdated Show resolved Hide resolved
docs/source/ko/guides/integrations.md Outdated Show resolved Hide resolved
docs/source/ko/guides/integrations.md Outdated Show resolved Hide resolved
docs/source/ko/guides/integrations.md Outdated Show resolved Hide resolved
docs/source/ko/guides/integrations.md Outdated Show resolved Hide resolved
docs/source/ko/guides/integrations.md Outdated Show resolved Hide resolved
docs/source/ko/guides/integrations.md Show resolved Hide resolved
docs/source/ko/guides/integrations.md Outdated Show resolved Hide resolved
@heuristicwave
Copy link
Contributor

@cjfghk5697 The content of the text was extensive, so it took a long time to review;;

@Wauplin I've reviewed this PR, and it looks good to me.
Would you mind merging this PR, please?

Copy link
Contributor

@Wauplin Wauplin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cjfghk5697 @heuristicwave! Merging it now :)

@Wauplin Wauplin merged commit af0836e into huggingface:main Jun 13, 2024
2 checks passed
Wauplin added a commit that referenced this pull request Jun 14, 2024
* docs: ko: guides/integrations.md

* feat: nmt draft

* feat: nmt draft

* fix: manual edits

* Apply suggestions from code review

* fix: manual edits

* fix: manual edits

* fix: manual edits

* Apply suggestions from code review

Co-authored-by: usr/bin/ksh <[email protected]>
Co-authored-by: SeongWooChoi <[email protected]>

* Apply suggestions from code review

* Apply suggestions from code review

* Apply suggestions from code review

Co-authored-by: Jihun Lim <[email protected]>
Co-authored-by: SeongWooChoi <[email protected]>

* Apply suggestions from code review

Co-authored-by: Jihun Lim <[email protected]>

---------

Co-authored-by: usr/bin/ksh <[email protected]>
Co-authored-by: SeongWooChoi <[email protected]>
Co-authored-by: Lucain <[email protected]>
Co-authored-by: Jihun Lim <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants