Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Active Prank Issue Causing Deploy Crash During Broadcast #49

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

vnmrtz
Copy link

@vnmrtz vnmrtz commented Aug 22, 2023

There is a bug within the existing implementation of the deploy function in HuffConfig.sol. Specifically, if a user intends to broadcast the deployment of the huff contract to a network, the ongoing active prank in the creation_code_with_args function disrupts the transaction flow, leading to a transaction failure. Consequently, this renders the deployment of huff contracts across any network utilising this framework unfeasible. The resultant console output below underscores this situation:

Error: 
You have an active prank. Broadcasting and pranks are not compatible. Disable one or the other

To address this predicament, I've incorporated the vm.stopPrank() invocation just prior to the commencement of the broadcast. This strategic inclusion effectively resolves the bug:

Script ran successfully.

@vnmrtz vnmrtz changed the title Fixed Active Prank Issue Causing Deploy Crash During Broadcast Fix Active Prank Issue Causing Deploy Crash During Broadcast Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant